[webkit-reviews] review granted: [Bug 59031] initial set of tests for new results.html file : [Attachment 90439] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 21 09:57:47 PDT 2011


Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 59031: initial set of tests for new results.html file
https://bugs.webkit.org/show_bug.cgi?id=59031

Attachment 90439: Patch
https://bugs.webkit.org/attachment.cgi?id=90439&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90439&action=review

Ojan and I discussed moving this into LayoutTests/fast/harness so it'll be run
automatically (in a follow up patch).

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:589
> +<script src="json_results_test.js"></script>

Nit: Please add a comment explaining why this doesn't run when the user is
viewing results.html.


More information about the webkit-reviews mailing list