[webkit-reviews] review granted: [Bug 52917] REGRESSION (r75543): Styles bleed into new shadow DOM (like slider and video) : [Attachment 90381] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 52917: REGRESSION (r75543): Styles bleed into new shadow DOM (like slider
and video)
https://bugs.webkit.org/show_bug.cgi?id=52917

Attachment 90381: Patch
https://bugs.webkit.org/attachment.cgi?id=90381&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90381&action=review

> LayoutTests/fast/css/shadow-dom-scope.html:45
> +    runSelectorTest(NO_MATCH, 'div');
> +    runSelectorTest(NO_MATCH, '*');
> +    runSelectorTest(NO_MATCH, 'body *');

There are no MATCH tests.  Are MATCH cases covered by existing tests?

> Source/WebCore/ChangeLog:35
> +	   * dom/ShadowRoot.h: Added.

This line looks the file is added.

> Source/WebCore/ChangeLog:38
> +	   * dom/TreeScope.h: Added.

ditto.

> Source/WebCore/css/CSSStyleSelector.cpp:755
> +private:

nit: We usually put a blank line before it.

> Source/WebCore/css/CSSStyleSelector.cpp:756
> +    static bool m_matchingUARules;

I wondered if such global variable was ok, and found there were some other
instances of global variables...