[webkit-reviews] review granted: [Bug 59082] [GTK] DRT: implement eventSender.scalePageBy : [Attachment 90504] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 59082: [GTK] DRT: implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=59082

Attachment 90504: proposed patch
https://bugs.webkit.org/attachment.cgi?id=90504&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90504&action=review

Awesome! Thanks for implementing this.

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:787
> +void DumpRenderTreeSupportGtk::scale(WebKitWebView* webView, float
scaleFactor, float x, float y)

Please name this method scalePageBy to match the name of the callback in DRT.
This will make it more obvious why this is needed above the scaling options we
already have in our API.