[webkit-reviews] review granted: [Bug 58914] Content of <summary> should be forwarded through the shadow DOM : [Attachment 90476] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 21 08:54:30 PDT 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted  review:
Bug 58914: Content of <summary> should be forwarded through the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=58914

Attachment 90476: Patch
https://bugs.webkit.org/attachment.cgi?id=90476&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
I slept on it and I am now generally okay with the approach as a first stab. I
would still like to explore the role of <content> being more active:
1) light children attach first, but all of their renderers are stashed in to a
map
2) shadow DOM attaches next
3) any time a <content> element is found, it looks in the map, collects
matching renderers, and inserts them into the render tree in its place.

Also, keep the new class in Node.cpp for now. We can split it out later.
NodeRenderParentDetector seems like a good name.


More information about the webkit-reviews mailing list