[webkit-reviews] review granted: [Bug 59096] Split GlyphPage from GlyphPageTreeNode.h into its own header : [Attachment 90522] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 59096: Split GlyphPage from GlyphPageTreeNode.h into its own header
https://bugs.webkit.org/show_bug.cgi?id=59096

Attachment 90522: Patch
https://bugs.webkit.org/attachment.cgi?id=90522&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90522&action=review

r=me

> Source/WebCore/platform/graphics/GlyphPage.h:77
> +    static const size_t size = 256; // Covers Latin-1 in a single page.

Can you move this to the top of the file and give it a more meaningful name?
Not sure if you have to add a g or k for static consts.

> Source/WebCore/platform/graphics/GlyphPage.h:141
> +    // Separate arrays, rather than array of GlyphData, to save space.

Not sure what you mean here. Can you rephrase it