[webkit-reviews] review denied: [Bug 52513] SVG feDropShadow implementation of SVG Filters 1.2 : [Attachment 90515] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 21 06:04:43 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has denied Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 52513: SVG feDropShadow implementation of SVG Filters 1.2
https://bugs.webkit.org/show_bug.cgi?id=52513

Attachment 90515: Patch
https://bugs.webkit.org/attachment.cgi?id=90515&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90515&action=review

Patch looks great, one problem though leading to r-:

> Source/WebCore/svg/SVGFEDropShadowElement.cpp:130
> +    RefPtr<RenderStyle> filterStyle = styleForRenderer();

styleForRenderer()? SVGFEDropShadowElement has it's own renderer through
SVGFilterPrimitiveStandardAttributes. You have to ask your renderer for the
style, don't do manual style resolution!
(I guess you copied that from another wrong SVGFE* Element?)


More information about the webkit-reviews mailing list