[webkit-reviews] review granted: [Bug 58993] Web Inspector: persist local resource history between inspector / browser launches. : [Attachment 90365] [PATCH] With the loaderId check.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 21 04:25:01 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 58993: Web Inspector: persist local resource history between inspector /
browser launches.
https://bugs.webkit.org/show_bug.cgi?id=58993

Attachment 90365: [PATCH] With the loaderId check.
https://bugs.webkit.org/attachment.cgi?id=90365&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90365&action=review

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:306
>	   resource.frameId = frame.id;

Consider passing all of these values as parameter to the constructor.


More information about the webkit-reviews mailing list