[webkit-reviews] review granted: [Bug 59044] [Qt][WK2] Emit QWKPage::urlChanged() when navigating within the same document. : [Attachment 90453] Proposed patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 59044: [Qt][WK2] Emit QWKPage::urlChanged() when navigating within the same
document.
https://bugs.webkit.org/show_bug.cgi?id=59044

Attachment 90453: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=90453&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90453&action=review

>>>> Source/WebKit2/UIProcess/API/qt/ClientImpl.h:46
>>>> +void qt_wk_didSameDocumentNavigationForFrame(WKPageRef page, WKFrameRef
frame, WKSameDocumentNavigationType type, WKTypeRef userData, const void
*clientInfo);
>>> 
>>> The parameter name "page" adds no information, so it should be removed. 
[readability/parameter_name] [5]
>> 
>> The parameter name "frame" adds no information, so it should be removed. 
[readability/parameter_name] [5]
> 
> The parameter name "type" adds no information, so it should be removed. 
[readability/parameter_name] [5]

I agree with the style guide here :-) only clientInfo and userData brings value