[webkit-reviews] review granted: [Bug 58807] Create RIAA class for GraphicsContext::save() and restore() : [Attachment 90490] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 20 22:06:14 PDT 2011


Eric Seidel <eric at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 58807: Create RIAA class for GraphicsContext::save() and restore()
https://bugs.webkit.org/show_bug.cgi?id=58807

Attachment 90490: Patch
https://bugs.webkit.org/attachment.cgi?id=90490&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90490&action=review

LGTM.

> Source/WebCore/rendering/RenderFileUploadControl.cpp:212
> +    GraphicsContextStateSaver stateSaver(*paintInfo.context, false);

I think we should turn this bool into an Enum at some point.


More information about the webkit-reviews mailing list