[webkit-reviews] review granted: [Bug 59054] WebKit2: Unconfirmed inline input session persists after reload : [Attachment 90464] proposed fix

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 59054: WebKit2: Unconfirmed inline input session persists after reload
https://bugs.webkit.org/show_bug.cgi?id=59054

Attachment 90464: proposed fix
https://bugs.webkit.org/attachment.cgi?id=90464&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90464&action=review

r=me

If either of the FIXMEs is a really bug, please file a follow-up.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1545
> +    // FIXME: didCommitLoadForFrame comes too late when restoring a page
from b/f cache, making us disable secure event mode in password fields.
> +    // FIXME: A load going on in one frame shouldn't affect typing in
sibling frames.

Do these FIXMEs represent real bugs that can occur in practice?