[webkit-reviews] review granted: [Bug 59046] With a non-1 page scale, scrolling to reveal selection fails : [Attachment 90474] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 20 19:06:09 PDT 2011
Maciej Stachowiak <mjs at apple.com> has granted mitz at webkit.org's request for
review:
Bug 59046: With a non-1 page scale, scrolling to reveal selection fails
https://bugs.webkit.org/show_bug.cgi?id=59046
Attachment 90474: Patch
https://bugs.webkit.org/attachment.cgi?id=90474&action=review
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90474&action=review
r=me
> Source/WebCore/rendering/RenderObject.cpp:1164
> if (!v->hasLayer() || !v->layer()->isComposited() ||
v->layer()->backing()->paintingGoesToWindow()) {
> - v->repaintViewRectangle(r, immediate);
> + IntRect repaintRectangle = r;
> + if (v->hasLayer() && v->layer()->transform() &&
v->layer()->isComposited() && v->layer()->backing()->paintingGoesToWindow())
> + repaintRectangle = v->layer()->transform()->mapRect(r);
> + v->repaintViewRectangle(repaintRectangle, immediate);
The logic here is a bit squarely. You test some conditions and then similar or
opposite looking ones right inside that if. I wonder if this can be refactored
to be more clear, though I have no specific suggestions.
More information about the webkit-reviews
mailing list