[webkit-reviews] review denied: [Bug 59045] Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D. : [Attachment 90454] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 20 17:37:31 PDT 2011


Kenneth Russell <kbr at google.com> has denied Alexey Marinichev
<amarinichev at chromium.org>'s request for review:
Bug 59045: Check for null m_context in WebGLLayerChromium and add resetting
platform layer's context in the destructor of GraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=59045

Attachment 90454: Patch
https://bugs.webkit.org/attachment.cgi?id=90454&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90454&action=review

The code change looks good. We've talked offline about the fact that it's only
feasible to test this in an automated fashion with a Chromium browser test,
which is being worked on. Unfortunately there's a problem with the ChangeLog
that needs to be fixed.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

The commit queue will reject this patch because of the presence of this line.
You'll need to update it with information about the testing status.


More information about the webkit-reviews mailing list