[webkit-reviews] review granted: [Bug 59014] Support DataView in workers : [Attachment 90376] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 20 13:36:59 PDT 2011
Kenneth Russell <kbr at google.com> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 59014: Support DataView in workers
https://bugs.webkit.org/show_bug.cgi?id=59014
Attachment 90376: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=90376&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90376&action=review
Looks good. One minor comment about the test.
> LayoutTests/fast/canvas/webgl/resources/worker-data-view-test.js:2
> + var array = new Uint8Array(4);
It would be safer to write this as "new Uint32Array(1)".
More information about the webkit-reviews
mailing list