[webkit-reviews] review denied: [Bug 58858] reftest mismatch doesn't work : [Attachment 90142] add-sample-reftests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 20 11:54:34 PDT 2011


Dmitry Titov <dimich at chromium.org> has denied Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 58858: reftest mismatch doesn't work
https://bugs.webkit.org/show_bug.cgi?id=58858

Attachment 90142: add-sample-reftests
https://bugs.webkit.org/attachment.cgi?id=90142&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
When I aply this patch and run:

build-webkit
new-run-webkit-tests LayoutTests/fast/harness/

I get:

Regressions: Unexpected image mismatch : (2)
  fast/harness/sample-fail-mismatch-reftest.html = IMAGE
  fast/harness/sample-mismatch-reftest.html = IMAGE

The images are similar for first test and different for the second, but they
both fail due to image mismatch.
Note this is not a Chromium DRT, it's the regular mac build of WebKit.

I would expect only one of those to fail, and also it would be nice to add the
'expected to fail' test to other platform's test_expectations.txt file.


More information about the webkit-reviews mailing list