[webkit-reviews] review denied: [Bug 58934] arc() should add a circle to the path when start and end angles are far enough apart : [Attachment 90359] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Matthew Delaney <mdelaney at apple.com>'s request for
review:
Bug 58934: arc() should add a circle to the path when start and end angles are
far enough apart
https://bugs.webkit.org/show_bug.cgi?id=58934

Attachment 90359: Patch
https://bugs.webkit.org/attachment.cgi?id=90359&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=90359&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:856
> +    if (anticlockwise && sa - ea >= 2.0f * piFloat) {

The coding style guidelines says that you should just write this as 2 *
piFloat.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:859
> +	   m_path.addArc(FloatPoint(x, y), r, sa, sa - piFloat, anticlockwise);

> +	   m_path.addArc(FloatPoint(x, y), r, sa - piFloat, sa, anticlockwise);


This can be done as a single 2π arc.