[webkit-reviews] review denied: [Bug 58886] Web Inspector: Render non-document HTML resources as HTML : [Attachment 90351] Patch with fixes

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 58886: Web Inspector: Render non-document HTML resources as HTML
https://bugs.webkit.org/show_bug.cgi?id=58886

Attachment 90351: Patch with fixes
https://bugs.webkit.org/attachment.cgi?id=90351&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90351&action=review

> Source/WebCore/inspector/front-end/NetworkItemView.js:48
> +	   var responseView = new WebInspector.ResourceSourceFrame(resource);

You could reuse existing SourceFrame in case previewView is instance of
ResourceSourceFrame. In fact, you should adjust resourceViewForResource to
cache only SourceFrame views.

> Source/WebCore/inspector/front-end/Resource.js:795
> +	       if (data == null)

pending callbacks should be notified upon missing content.

> Source/WebCore/inspector/front-end/ResourceHTMLView.js:52
> +	   this.element.textContent = "";

this.element.removeChildren()

> Source/WebCore/inspector/front-end/ResourceView.js:49
> +	   return new WebInspector.ResourceHTMLView(resource);

Reuse SourceFrame-based views when possible as per comment above.

> Source/WebCore/inspector/front-end/ResourceView.js:80
> +	   if (WebInspector.ResourceJSONView.parseJSON(resource.content))

This seems to be a bit too expensive. Testing for the prototype would be
sufficient.