[webkit-reviews] review denied: [Bug 58435] [Qt] Upstream Symbian platform plugin. : [Attachment 90355] platformpluginV1

[bugzilla-daemon at webkit.org]

Alexis Menard <alexis.menard at openbossa.org> has denied yi shen
<yi.4.shen at nokia.com>'s request for review:
Bug 58435: [Qt] Upstream Symbian platform plugin.
https://bugs.webkit.org/show_bug.cgi?id=58435

Attachment 90355: platformpluginV1
https://bugs.webkit.org/attachment.cgi?id=90355&action=review

------- Additional Comments from Alexis Menard <alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90355&action=review

Where is the implementation for the video part????

> Source/WebKit/qt/symbian/platformplugin/WebPlugin.cpp:26
> +#include <akndiscreetpopup.h>

Sorting?

> Source/WebKit/qt/symbian/platformplugin/qwebkitplatformplugin.h:32
> +#if defined(WTF_USE_QT_MULTIMEDIA) && WTF_USE_QT_MULTIMEDIA

I believe you can use USE(QT_MULTIMEDIA), moc will still be run on the classes
below.