[webkit-reviews] review granted: [Bug 57480] Inspector doesn't come to the front when a breakpoint is hit in the debugger in WebKit2 : [Attachment 90353] Proposed Change

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 57480: Inspector doesn't come to the front when a breakpoint is hit in the
debugger in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57480

Attachment 90353: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=90353&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90353&action=review

>> Source/WebKit2/ChangeLog:1
>> +2011-04-20	Timothy Hatcher  <timothy at apple.com>
> 
> ChangeLog entry has no bug number  [changelog/bugnumber] [5]

I think check-webkit-style doesn't know about https: for short bug URLs. You
should file a bug about that.

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:139
> +    // FIXME: support bring to front in docked mode here.

You could put this FIXME in the Windows code, too.

> Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:197
> +void WebInspectorProxy::platformBringToFront()
> +{
> +    if (!m_inspectorWindow)
> +	   return;
> +
> +    ASSERT(::IsWindow(m_inspectorWindow));
> +    ::ShowWindow(m_inspectorWindow, SW_SHOW);
> +}

I don't think this will be sufficient on Windows. I think this would do the
trick instead:

::SetWindowPos(m_inspectorWindow, HWND_TOP, 0, 0, 0, 0, SWP_SHOWWINDOW |
SWP_NOMOVE | SWP_NOSIZE);