[webkit-reviews] review requested: [Bug 58994] JSString::resolveRope inefficient for common 2 fiber case : [Attachment 90346] Patch that splits resolveRope into common and slow cases

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 58994: JSString::resolveRope inefficient for common 2 fiber case
https://bugs.webkit.org/show_bug.cgi?id=58994

Attachment 90346: Patch that splits resolveRope into common and slow cases
https://bugs.webkit.org/attachment.cgi?id=90346&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
Improves performance on dromaeo DOM-query benchmark.

Suspect this will generally improve performance.

Considered inlining the fast case, but felt the method was a little long for
that.  Although there are only two call sites for resolveRope, both are in
JSString.h in common methods that will be inlined themselves.  This could cause
code bloat.