[webkit-reviews] review granted: [Bug 58960] [Chromium]Mac UI polish to add left/right padding space for autofill popup window. : [Attachment 90299] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 58960: [Chromium]Mac UI polish to add left/right padding space for autofill
popup window.
https://bugs.webkit.org/show_bug.cgi?id=58960

Attachment 90299: Patch
https://bugs.webkit.org/attachment.cgi?id=90299&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90299&action=review

Seems OK to me besides the nits below.

> Source/WebCore/ChangeLog:9
> +	   No new test because Chromium Autofill popup window doesn't have any
test framework.

Thank you for explaining.

> Source/WebCore/ChangeLog:12
> +	   The code should be removed after Autofill popup window logic is
separated from WebKit to Chromium.

Can you provide more context? like a bug link?

> Source/WebCore/rendering/RenderThemeChromiumMac.h:59
> +    int popupInternalPaddingLeft(RenderStyle*) const;
> +    int popupInternalPaddingRight(RenderStyle*) const;

Aren't these virtual calls? (we always mark virtual calls as virtual even
though it's not strictly required by the spec).