[webkit-reviews] review granted: [Bug 58926] BitmapImage::destroyMetadataAndNotify should clear m_checkedForSolidColor : [Attachment 90307] Fix assertion

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 58926: BitmapImage::destroyMetadataAndNotify should clear
m_checkedForSolidColor
https://bugs.webkit.org/show_bug.cgi?id=58926

Attachment 90307: Fix assertion
https://bugs.webkit.org/attachment.cgi?id=90307&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90307&action=review

> Source/WebCore/platform/graphics/Image.cpp:117
> +    if (this->isBitmapImage())
> +	   ASSERT(static_cast<BitmapImage*>(this)->notSolidColor());

How about ASSERT(!isBitmapImage() || notSolidColor()) ?
Then you don't need the ASSERT_DISABLED stuff.
Why the this-> ?