[webkit-reviews] review granted: [Bug 58687] KeepAlive is called everytime JS is executed but is not always necessary : [Attachment 90078] Patch to only call Frame::keepAlive when necessary, not every time we call into JS.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 19 15:09:11 PDT 2011


Adam Barth <abarth at webkit.org> has granted Greg Simon
<gregsimon at chromium.org>'s request for review:
Bug 58687: KeepAlive is called everytime JS is executed but is not always
necessary
https://bugs.webkit.org/show_bug.cgi?id=58687

Attachment 90078: Patch to only call Frame::keepAlive when necessary, not every
time we call into JS.
https://bugs.webkit.org/attachment.cgi?id=90078&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90078&action=review

> Source/WebCore/ChangeLog:5
> +	   Fix comment

What does "fix comment" mean?

> Source/WebCore/ChangeLog:11
> +	   No new tests since it is an optimization of standard behavior.

Is there some performance test that shows improvement after this patch?  If so,
which one and how much?


More information about the webkit-reviews mailing list