[webkit-reviews] review denied: [Bug 58925] REGRESSION(r55762): Highlight color can't be copied in gmail : [Attachment 90260] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 19 15:01:06 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has denied Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 58925: REGRESSION(r55762): Highlight color can't be copied in gmail
https://bugs.webkit.org/show_bug.cgi?id=58925
Attachment 90260: Patch
https://bugs.webkit.org/attachment.cgi?id=90260&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90260&action=review
> Source/WebCore/editing/markup.cpp:455
> +static bool hasVisibleBackgroundColor(CSSStyleDeclaration* style)
> +{
> + if (!style)
> + return false;
> + RefPtr<CSSValue> colorValue =
style->getPropertyCSSValue(CSSPropertyBackgroundColor);
> + if (!colorValue || !colorValue->isPrimitiveValue())
> + return false;
> +
> + CSSPrimitiveValue* primitiveColor =
static_cast<CSSPrimitiveValue*>(colorValue.get());
> + RGBA32 rgba = 0;
> +
> + if (primitiveColor->primitiveType() == CSSPrimitiveValue::CSS_RGBCOLOR)
> + rgba = primitiveColor->getRGBA32Value();
> + else
> + CSSParser::parseColor(rgba, colorValue->cssText());
> + return alphaChannel(rgba);
> +}
There's hasTransparentBackgroundColor in Editor.cpp. Please share code with
that.
More information about the webkit-reviews
mailing list