[webkit-reviews] review granted: [Bug 58921] [chromium] linux chromium doesn't set click count for mouse up events in WebInputEventFactory.cpp. : [Attachment 90256] Revise the ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 19 14:55:28 PDT 2011


Tony Chang <tony at chromium.org> has granted yzshen at chromium.org's request for
review:
Bug 58921: [chromium] linux chromium doesn't set click count for mouse up
events in WebInputEventFactory.cpp.
https://bugs.webkit.org/show_bug.cgi?id=58921

Attachment 90256: Revise the ChangeLog
https://bugs.webkit.org/attachment.cgi?id=90256&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
I think this patch is correct, but it would be nice to add a layout test for
this.  The benefit of a layout test is that it would ensure that we get
consistent results across platforms.  Specifically, you can use
window.eventSender.leapForward and mouseDown/Up to simulate mouse events.  You
might need to add eventSender.clickCount() for this.  This could be a follow up
patch.


More information about the webkit-reviews mailing list