[webkit-reviews] review denied: [Bug 58823] [chromium] expose title direction to webkit client : [Attachment 90108] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied  review:
Bug 58823: [chromium] expose title direction to webkit client
https://bugs.webkit.org/show_bug.cgi?id=58823

Attachment 90108: Patch
https://bugs.webkit.org/attachment.cgi?id=90108&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90108&action=review

> Source/WebKit/chromium/public/WebFrameClient.h:211
> +    virtual void didReceiveTitle(WebFrame*, const WebString& title,
WebTextDirection direction = WebTextDirectionDefault) { }

how does this not break chromium?  since chromium (RenderView) implements
WebFrameClient, i think you probably meant to write two didReceiveTitle
functions and have the newer one delegate to the older one, like this:

  virtual void didReceiveTitle(WebFrame*, const WebString& title) { }
  virtual void didReceiveTitle(WebFrame* frame, const WebString& title,
WebTextDirection direction)
  {
      didReceiveTitle(frame, title);
  }