[webkit-reviews] review granted: [Bug 58862] [Windows, WinCairo] Teach DIBPixelData to Write to a file : [Attachment 90150] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 58862: [Windows, WinCairo] Teach DIBPixelData to Write to a file
https://bugs.webkit.org/show_bug.cgi?id=58862

Attachment 90150: Patch
https://bugs.webkit.org/attachment.cgi?id=90150&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90150&action=review

> Source/WebCore/platform/graphics/win/DIBPixelData.cpp:32
> +const WORD s_bitmapType = 0x4d42;
> +const WORD s_bitmapPixelsPerMeter = 2834; // 72 dpi

No need for the s_ prefixes here. But you should mark them "static".

> Source/WebCore/platform/graphics/win/DIBPixelData.h:52
> +	   void writeToFile(LPCWSTR);

Maybe this function should be wrapped in #ifndef NDEBUG?