[webkit-reviews] review granted: [Bug 57298] Add tests to PrettyPatch : [Attachment 87260] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Caio Marcelo de Oliveira
Filho <caio.oliveira at openbossa.org>'s request for review:
Bug 57298: Add tests to PrettyPatch
https://bugs.webkit.org/show_bug.cgi?id=57298

Attachment 87260: Patch
https://bugs.webkit.org/attachment.cgi?id=87260&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87260&action=review

> Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb:24
> +	   20528 => [nil, 1, 4, 3, 7],
> +	   21120 => [nil, 2, 4, 2, 6],
> +	   21151 => [nil, 4, 9, 1, 16],
> +	   21152 => [nil, 2, 17, 7, 23],
> +	   21388 => [nil, 3, 4, 2, 6],

Why no titles for these patches?

> Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb:45
> +    def get_patch_uri(id)
> +	   "https://bugs.webkit.org/attachment.cgi?id=" + id.to_s
> +    end
> +
> +    def get_patch(id)
> +	   result = nil
> +	   patch_uri = get_patch_uri(id)
> +	   begin
> +	       result = open(patch_uri) { |f| result = f.read }
> +	   rescue => exception
> +	       assert(false, "Fail to get patch " + patch_uri)
> +	   end
> +	   result
> +    end

It seems a little unfortunate for these tests to have to hit the network.