[webkit-reviews] review granted: [Bug 58860] make results file work with audio and reftests : [Attachment 90132] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 18 19:14:27 PDT 2011


Eric Seidel <eric at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 58860: make results file work with audio and reftests
https://bugs.webkit.org/show_bug.cgi?id=58860

Attachment 90132: Patch
https://bugs.webkit.org/attachment.cgi?id=90132&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90132&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:154
> +    // FIXME: use audio tags for AUDIO tests?

woh, that'd be cool.

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:264
> +	 row += resultLink(test_prefix, '-expected.wav', 'expected');
> +	 row += resultLink(test_prefix, '-actual.wav', 'actual');

Are they always .wav files?

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:292
> +		 resultLink(test_prefix, '-actual.png', 'actual') +

You repeat these suffixes a lot.  Maybe we should use constants?


More information about the webkit-reviews mailing list