[webkit-reviews] review granted: [Bug 58851] add incremental decoding to WebP decoder : [Attachment 90120] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Pascal Massimino
<pascal.massimino at gmail.com>'s request for review:
Bug 58851: add incremental decoding to WebP decoder
https://bugs.webkit.org/show_bug.cgi?id=58851

Attachment 90120: Patch
https://bugs.webkit.org/attachment.cgi?id=90120&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90120&action=review

Ideally pkasting would take a look at well.  Thanks!

> Source/WebCore/ChangeLog:12
> +	Testing buffered connection is flaky: one need a very big picture
> +	to test with and an emulated clogged-connection. And even then,
> +	there's no guaranty the test will eventually chose the
> +	incremental-decoding code path.

Looks like you have tabs here.	We use spaces instead of tabs.

> Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp:108
> +	   // FIXME: must be updated when WebP supports alpha-channel.

We generally prefer complete sentences for comments.  I would write something
like:

// FIXME: We currently hard code false below because libwebp doesn't support
alpha yet.