[webkit-reviews] review granted: [Bug 58798] WebKit needs to stop importing <AppKit/NSTextChecker.h> : [Attachment 90057] Patch (v1)

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted Jia Pu <jpu at apple.com>'s
request for review:
Bug 58798: WebKit needs to stop importing <AppKit/NSTextChecker.h>
https://bugs.webkit.org/show_bug.cgi?id=58798

Attachment 90057: Patch (v1)
https://bugs.webkit.org/attachment.cgi?id=90057&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90057&action=review

r=me

> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:80
> +- (NSString *)languageForWordRange:(NSRange)range inString:(NSString
*)string orthography:(NSOrthography *)orthography;

I think you should drop the comment.  In other places we call the category
“AppKitSecretsIKnow”.

> Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:36
> +- (NSString *)languageForWordRange:(NSRange)range inString:(NSString
*)string orthography:(NSOrthography *)orthography;

Same as above.