[webkit-reviews] review granted: [Bug 58088] [CG] Use vImage (un)premultiplyImageData functions for get/putImageData with IOSurfaces : [Attachment 90054] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 58088: [CG] Use vImage (un)premultiplyImageData functions for
get/putImageData with IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=58088

Attachment 90054: Patch
https://bugs.webkit.org/attachment.cgi?id=90054&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90054&action=review

> Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp:41
> +struct vImageBufferPair {

This is no longer a vImageBufferPair.

> Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp:96
> +    vImagePermuteChannels_ARGB8888(&dest, &dest, map,  kvImageDoNotTile);

Is vImagePermuteChannels_ARGB8888 documented to work when source and
destination are the same?

Two spaces before kVImageDoNotTile.

> Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp:217
> +	       const uint8_t map[4] = { 2, 1, 0, 3 };

'map' is a little obscure here. You need a comment to say what this permute is
doing.

> Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp:354
> +	       const uint8_t map[4] = { 2, 1, 0, 3 };
> +	       vImagePermuteChannels_ARGB8888(&src, &dest, map,
kvImageNoFlags);

Ditto