[webkit-reviews] review denied: [Bug 58656] [Qt] X11: Text selection is causing oncopy event to be called : [Attachment 90025] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 58656: [Qt] X11: Text selection is causing oncopy event to be called
https://bugs.webkit.org/show_bug.cgi?id=58656

Attachment 90025: Patch
https://bugs.webkit.org/attachment.cgi?id=90025&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90025&action=review

> LayoutTests/editing/pasteboard/text-selection-expected.txt:2
> +This file tests if text selection is causing oncopy event to be called. This
test requires DRT.
> +oncopy event called 1 time

Please explain that the text below should read that the oncopy event was
triggered only once.
The output could be something like:

This file tests if text selection causes oncopy events. This test requires DRT.


Selecting text with mouse, no copy events should occur:
Event count: 0

Copying text, 1 copy event should occur:
Event count: 1

> LayoutTests/editing/pasteboard/text-selection.html:37
> +    eventSender.mouseMoveTo(0, 0);
> +    for (var i = 0; i < 3; i++) {
> +	   eventSender.mouseDown();
> +	   eventSender.mouseUp();
> +    }

This is making a triple-click to select the whole line?
Will it work on other platforms? This test will be run on the Mac, Chromium,
Gtk ports, etc. I don't know if they all support triple-click selection.
It would be cleaner to do a normal selection via mouseDown, mouseMove, mouseUp
over the text.