[webkit-reviews] review denied: [Bug 58300] [Windows, WinCairo] Support Transparent WebKit Background : [Attachment 89997] Try touching a WebKit/win vsprop to force rebuild

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 18 09:33:00 PDT 2011


Eric Seidel <eric at webkit.org> has denied Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 58300: [Windows, WinCairo] Support Transparent WebKit Background
https://bugs.webkit.org/show_bug.cgi?id=58300

Attachment 89997: Try touching a WebKit/win vsprop to force rebuild
https://bugs.webkit.org/attachment.cgi?id=89997&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89997&action=review

Looks like it breaks the win-ews.

>> Source/WebKit/win/WebView.cpp:2648
>> +HRESULT STDMETHODCALLTYPE WebView::initTransparentViewWithFrame( 
> 
> Extra space after ( in function call	[whitespace/parens] [4]

This is a valid complaint, please fix.	You have whitespace at the end of your
line.

>> Source/WebKit/win/WebView.h:129
>> +	virtual HRESULT STDMETHODCALLTYPE initTransparentViewWithFrame( 
> 
> Extra space after ( in function call	[whitespace/parens] [4]

Same here.


More information about the webkit-reviews mailing list