[webkit-reviews] review granted: [Bug 58784] [Chromium] Enable QUOTA API at runtime if enable-quota flag is given : [Attachment 90031] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 18 09:24:25 PDT 2011
David Levin <levin at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 58784: [Chromium] Enable QUOTA API at runtime if enable-quota flag is given
https://bugs.webkit.org/show_bug.cgi?id=58784
Attachment 90031: Patch
https://bugs.webkit.org/attachment.cgi?id=90031&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90031&action=review
Please wait for Darin's ok since you did a chromium public api change.
> Source/WebKit/chromium/src/WebRuntimeFeatures.cpp:323
> +void WebRuntimeFeatures::enableQuota(bool enable)
I suspect you'll trigger a warning and thus a compile error due to unused
enable when QUOTA isn't enabled.
More information about the webkit-reviews
mailing list