[webkit-reviews] review granted: [Bug 42541] WebKitTestRunner needs layoutTestController.pathToLocalResource : [Attachment 90032] fix patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Chang Shu <cshu at webkit.org>'s request
for review:
Bug 42541: WebKitTestRunner needs layoutTestController.pathToLocalResource
https://bugs.webkit.org/show_bug.cgi?id=42541

Attachment 90032: fix patch
https://bugs.webkit.org/attachment.cgi?id=90032&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90032&action=review

OK.

> Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:61
> +    return JSStringRetain(url); // Do nothing on mac.

That's because mac doesn't disable access to file: urls?

> Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:64
> +    return JSStringRetain(url); // TODO.

I think we normally use FIXME.