[webkit-reviews] review denied: [Bug 58656] [Qt] X11: Text selection is causing oncopy event to be called : [Attachment 90021] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 58656: [Qt] X11: Text selection is causing oncopy event to be called
https://bugs.webkit.org/show_bug.cgi?id=58656

Attachment 90021: Patch
https://bugs.webkit.org/attachment.cgi?id=90021&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90021&action=review

> LayoutTests/editing/pasteboard/text-selection-expected.txt:2
> +This file tests if text selection is causing oncopy event to be called. This
test requires DRT.
> +oncopy event called

While this output is correct AFAICT, it certainly looks wrong.
Please format the output in a way that makes it clear what is being tested and
what the expected results are.

> Source/WebKit/qt/ChangeLog:13
> +	   Always when a text is selected the oncopy event is called, this
behavior is
> +	   not presented by browsers such as firefox and chrome. Now, when
selecting
> +	   a text, QtWebkit is making multi part-copies (with rich text
metadata), the multi-part
> +	   data can be obtained by data transfer interface.
> +	   Also, Copies to the clipboard of a selected image, is not supported
by browsers
> +	   like chrome and firefox and was removed from QtWebkit.

s/browsers such as//
s/firefox/Firefox/
s/chrome/Chrome/
s/a text/text/
s/QtWebkit/QtWebKit/

Can we actually obtain the multi-part selection via the data transfer interface
in QtWebKit today?