[webkit-reviews] review granted: [Bug 58537] Web Inspector: TAB should not move focus from the text editor while live editing : [Attachment 89791] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 58537: Web Inspector: TAB should not move focus from the text editor while
live editing
https://bugs.webkit.org/show_bug.cgi?id=58537

Attachment 89791: Patch
https://bugs.webkit.org/attachment.cgi?id=89791&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89791&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:243
> +	   var handleUndo =
this._mainPanel.handleUndoRedo.bind(this._mainPanel, 0);

Why do we prefer 0/1 to false/true here?

> Source/WebCore/inspector/front-end/TextViewer.js:951
> +	   this._setCaretLocation(newRange.endLine, newRange.endColumn);

Shouldn't we scroll the viewer to the new caret location?