[webkit-reviews] review denied: [Bug 58764] Web Inspector: Backspace in the Console is broken : [Attachment 90002] [PATCH] Suggested fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 18 02:04:52 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 58764: Web Inspector: Backspace in the Console is broken
https://bugs.webkit.org/show_bug.cgi?id=58764

Attachment 90002: [PATCH] Suggested fix
https://bugs.webkit.org/attachment.cgi?id=90002&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90002&action=review

> Source/WebCore/inspector/front-end/inspector.js:797
> +	       if (!selection.rangeCount || !selection.isCollapsed)

This will break backspace on non-empty selection. r- for this.


More information about the webkit-reviews mailing list