[webkit-reviews] review requested: [Bug 56672] Leaks beneath RenderSVGShadowTreeRootContainer::updateFromElement seen on SnowLeopard Intel Leaks : [Attachment 89993] Patch

[bugzilla-daemon at webkit.org]

Leo Yang <leo.yang at torchmobile.com.cn> has asked  for review:
Bug 56672: Leaks beneath RenderSVGShadowTreeRootContainer::updateFromElement
seen on SnowLeopard Intel Leaks
https://bugs.webkit.org/show_bug.cgi?id=56672

Attachment 89993: Patch
https://bugs.webkit.org/attachment.cgi?id=89993&action=review

------- Additional Comments from Leo Yang <leo.yang at torchmobile.com.cn>
I can't see the leak results from the above links. But I can see the following
leak in recent build, so I'm assume the bug was reporting the same issue.

Leak: 0x1165e1df0  size=464  zone: DefaultMallocZone_0x105f89000       
instance of 'WebCore::SVGShadowTreeRootElement', type C++, implemented in
WebCore       
	0x02fd30d8 0x00000001 0x02fd36d0 0x00000001	.0.......6......
	0x16600000 0x00000000 0x165a08b0 0x00000001	..`.......Z.....
	0x00000000 0x00000000 0x00000000 0x00000000	................
	0x07e34a00 0x00000001 0x00000000 0x00000000	.J..............
	0x00000000 0x00000000 0x00000000 0x00000000	................
	0x005c085c 0x00000000 0x00000000 0x00000000	\.\.............
	0x00000000 0x00000000 0x0ce6a1d0 0x00000001	................
	0x00000000 0x00000000 0x00000000 0x00000000	................
	... 
	Call stack: [thread 0x7fff70e15ca0]: | 0x2 | start | main |
dumpRenderTree(int, char const**) | runTestingServerLoop() |
runTest(std::string const&) | -[NSRunLoop(NSRunLoop) runMode:beforeDate:] |
CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoSources0 |
MultiplexerSource::perform() | URLConnectionClient::processEvents() |
URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayl
oad(XConnectionEventInfo<XClientEvent, XClientEventParams>*, long) |
URLConnectionClient::_clientDidReceiveData(__CFData const*,
URLConnectionClient::ClientConnectionEventQueue*) |
_NSURLConnectionDidReceiveData | -[WebCoreResourceHandleAsDelegate
connection:didReceiveData:lengthReceived:] |
WebCore::ResourceLoader::didReceiveData(WebCore::ResourceHandle*, char const*,
int, int) | WebCore::MainResourceLoader::didReceiveData(char const*, int, long
long, bool) | WebCore::ResourceLoader::didReceiveData(char const*, int, long
long, bool) | WebCore::MainResourceLoader::addData(char const*, int, bool) |
WebCore::DocumentLoader::receivedData(char const*, int) |
WebCore::DocumentLoader::commitLoad(char const*, int) |
WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int)
| -[WebDataSource(WebInternal) _receivedData:] | -[WebHTMLRepresentation
receivedData:withDataSource:] | -[WebFrame(WebInternal) _commitData:] |
WebCore::DocumentLoader::commitData(char const*, int) |
WebCore::DocumentWriter::addData(char const*, int, bool) |
WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter*, char
const*, int, bool) |
WebCore::XMLDocumentParser::append(WebCore::SegmentedString const&) |
WebCore::XMLDocumentParser::doWrite(WTF::String const&) | xmlParseChunk |
xmlParseXMLDecl | WebCore::startElementNsHandler(void*, unsigned char const*,
unsigned char const*, unsigned char const*, int, unsigned char const**, int,
int, unsigned char const**) |
WebCore::XMLDocumentParser::startElementNs(unsigned char const*, unsigned char
const*, unsigned char const*, int, unsigned char const**, int, int, unsigned
char const**) | WebCore::SVGUseElement::attach() |
WebCore::SVGStyledElement::attach() |
WebCore::RenderSVGShadowTreeRootContainer::updateFromElement() |
WebCore::SVGShadowTreeRootElement::create(WebCore::Document*,
WebCore::SVGUseElement*) | WTF::fastMalloc(unsigned long) | malloc |
malloc_zone_malloc