[webkit-reviews] review granted: [Bug 31500] webkit-patch land hangs if svn prompts for credentials : [Attachment 89967] Patch and updated unit tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 17 16:17:58 PDT 2011


Eric Seidel <eric at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 31500: webkit-patch land hangs if svn prompts for credentials
https://bugs.webkit.org/show_bug.cgi?id=31500

Attachment 89967: Patch and updated unit tests
https://bugs.webkit.org/attachment.cgi?id=89967&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89967&action=review

Seems good.

> Tools/Scripts/webkitpy/common/checkout/scm.py:324
> +class SVNAndGitSVNHasAuthorizationForRealmMixin:

I would have done this as an SVNRepository class, but this is OK.


More information about the webkit-reviews mailing list