[webkit-reviews] review granted: [Bug 31500] webkit-patch land hangs if svn prompts for credentials : [Attachment 89963] Patch and updated unit tests

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 31500: webkit-patch land hangs if svn prompts for credentials
https://bugs.webkit.org/show_bug.cgi?id=31500

Attachment 89963: Patch and updated unit tests
https://bugs.webkit.org/attachment.cgi?id=89963&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89963&action=review

Look beautiful.

> Tools/Scripts/webkitpy/common/net/credentials.py:151
> -	       password = getpass.getpass("%s password for %s: " % (self.host,
username))
> +	       password = User.prompt_password("%s password for %s: " %
(self.host, username))

This should really get the user object off the tool so we can mock it out
during testing.