[webkit-reviews] review requested: [Bug 58746] Move WebNodeHighlighter into its own file : [Attachment 89958] [PATCH] Extract into its own file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 17 13:11:20 PDT 2011


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 58746: Move WebNodeHighlighter into its own file
https://bugs.webkit.org/show_bug.cgi?id=58746

Attachment 89958: [PATCH] Extract into its own file
https://bugs.webkit.org/attachment.cgi?id=89958&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Some minor cleanup in the process:

  - fix WebInspectorClient constructor
  - remove "WebNodeHightlighter delegate" methods on
WebInspectorWindowController
    which were never called because it was never set to be the delegate.
  - added [super init] boilerplate to WebNodeHighligher's constructor

Also, the ObjC classes in WebInspectorClient don't properly initialize self.
They just call the super methods but don't assign to self. Should I fix those
up as well?


More information about the webkit-reviews mailing list