[webkit-reviews] review granted: [Bug 55965] Allow shadowing of history object : [Attachment 89625] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 17 10:10:28 PDT 2011


Adam Barth <abarth at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 55965: Allow shadowing of history object
https://bugs.webkit.org/show_bug.cgi?id=55965

Attachment 89625: Patch
https://bugs.webkit.org/attachment.cgi?id=89625&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89625&action=review

I'm still slightly worried about this patch, but I can't think of another test
to run.  Please be on the lookout for compatibility regressions!

>
LayoutTests/http/tests/history/cross-origin-replace-history-object-child-expect
ed.txt:6
> +CONSOLE MESSAGE: line 1: Unsafe JavaScript attempt to access frame with URL
http://localhost:8000/history/resources/cross-origin-replaces-history-object-ch
ild-iframe.html from frame with URL
http://127.0.0.1:8000/history/cross-origin-replace-history-object-child.html.
Domains, protocols and ports must match.

Where does this message come from?


More information about the webkit-reviews mailing list