[webkit-reviews] review denied: [Bug 58463] Switch HTTP pipelining from user default to private setting : [Attachment 89927] Patch v3

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied David Kilzer (ddkilzer) <ddkilzer at webkit.org>'s
request for review:
Bug 58463: Switch HTTP pipelining from user default to private setting
https://bugs.webkit.org/show_bug.cgi?id=58463

Attachment 89927: Patch v3
https://bugs.webkit.org/attachment.cgi?id=89927&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=89927&action=review

Did you forget to add the WKContext API for this? r- because of naming issues.

> Source/WebCore/platform/network/cf/ResourceRequest.h:92
> +	   static void setHttpPipeliningEnabled(bool flag);

“flag” is redundant. HTTP should be all-uppercase.

> Source/WebKit/mac/WebView/WebView.mm:2831
> ++ (BOOL)_httpPipeliningEnabled

HTTP should be all-uppercase

> Source/WebKit/mac/WebView/WebView.mm:2836
> ++ (void)_setHttpPipeliningEnabled:(BOOL)enabled

HTTP should be all-uppercase

> Source/WebKit2/UIProcess/WebContext.cpp:752
> +void WebContext::setHttpPipeliningEnabled(bool enabled)

HTTP should be all-uppercase.