[webkit-reviews] review denied: [Bug 58346] Convert media controls hooks to a client interface : [Attachment 89900] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Steve Lacey
<sjl at chromium.org>'s request for review:
Bug 58346: Convert media controls hooks to a client interface
https://bugs.webkit.org/show_bug.cgi?id=58346

Attachment 89900: Patch
https://bugs.webkit.org/attachment.cgi?id=89900&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89900&action=review

> Source/WebCore/html/shadow/MediaControlClient.h:38
> +class MediaControlClient : public HTMLDivElement {

This is interesting. If it's a subclass of an HTMLDivElement, it's probably not
a client. I was imagining MediaControlClient to not be a subclass of anything,
but maybe that would be too convoluted.

I think what you have is fine, but you need to get rid of the Client
designation. This is a base class, and the convention in WebKit is to use a
Base suffix. So this would be an HTMLMediaControlBase.h