[webkit-reviews] review granted: [Bug 58705] DFG JIT Add support for flow control (branch, jump). : [Attachment 89866] The patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 58705: DFG JIT Add support for flow control (branch, jump).
https://bugs.webkit.org/show_bug.cgi?id=58705

Attachment 89866: The patch
https://bugs.webkit.org/attachment.cgi?id=89866&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89866&action=review

r=me

> Source/JavaScriptCore/dfg/DFGGraph.h:56
> +    unsigned bytecodeOffset;

Can we call this bytecodeBegin?

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:622
> +	   // Integers
> +	   addBranch(m_jit.branchPtr(MacroAssembler::Equal, valueReg,
MacroAssembler::ImmPtr(JSValue::encode(jsNumber(0)))), notTaken);
> +	   MacroAssembler::Jump isNonZeroInteger =
m_jit.branchPtr(MacroAssembler::AboveOrEqual, valueReg,
JITCompiler::tagTypeNumberRegister);
> +
> +	   // Booleans
> +	   addBranch(m_jit.branchPtr(MacroAssembler::Equal, valueReg,
MacroAssembler::ImmPtr(JSValue::encode(jsBoolean(false)))), notTaken);

So slow! :(