[webkit-reviews] review granted: [Bug 58694] Add the ability for PageOverlays to fade in and out : [Attachment 89854] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 15 14:30:06 PDT 2011


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 58694: Add the ability for PageOverlays to fade in and out
https://bugs.webkit.org/show_bug.cgi?id=58694

Attachment 89854: Patch
https://bugs.webkit.org/attachment.cgi?id=89854&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89854&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:735
> +void WebPage::uninstallPageOverlay(PageOverlay* pageOverlay, bool fadeOut)

I think this would read better as an enum.


More information about the webkit-reviews mailing list