[webkit-reviews] review granted: [Bug 58688] Implement localize strings for windows WebKit2 : [Attachment 89841] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 58688: Implement localize strings for windows WebKit2
https://bugs.webkit.org/show_bug.cgi?id=58688

Attachment 89841: Patch
https://bugs.webkit.org/attachment.cgi?id=89841&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89841&action=review

> Source/WebCore/platform/win/LocalizedStringsWin.cpp:49
> +    ASSERT(length && length < WTF_ARRAY_LENGTH(dllPathBuffer));

This should be two separate assertions.

> Source/WebCore/platform/win/LocalizedStringsWin.cpp:64
> +static CFBundleRef webKitBundle()
> +{
> +    static CFBundleRef bundle = createWebKitBundle();
> +    ASSERT(bundle);
> +    return bundle;
> +}

We should expose this to WebKit1 and WebKit2 so they don't need their own
definitions.