[webkit-reviews] review denied: [Bug 58686] Add takeFocus callback to WKPageUIClient : [Attachment 89845] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 15 13:58:15 PDT 2011


Sam Weinig <sam at webkit.org> has denied Jeff Miller <jeffm at apple.com>'s request
for review:
Bug 58686: Add takeFocus callback to WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=58686

Attachment 89845: Patch
https://bugs.webkit.org/attachment.cgi?id=89845&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89845&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.h:152
> +typedef void (*WKPageTakeFocusCallback)(WKPageRef page, bool direction,
const void *clientInfo);

Instead of a bool, I think an enum would be better, e.g. WKFocusDirection.


More information about the webkit-reviews mailing list