[webkit-reviews] review granted: [Bug 58676] Views should be made visible before painting in WM_PRINTCLIENT messages : [Attachment 89817] [PATCH] Fix

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 58676: Views should be made visible before painting in WM_PRINTCLIENT
messages
https://bugs.webkit.org/show_bug.cgi?id=58676

Attachment 89817: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=89817&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89817&action=review

> Source/WebKit2/UIProcess/win/WebView.cpp:700
> +    if (!isVisible)
> +	   setIsVisible(true);
> +
>      paint(hdc, winRect);
>  
> +    if (!isVisible)
> +	   setIsVisible(false);

I think it's worth adding a comment explaining why we do this.

It's a little unfortunate that we don't have more fine-grained control of this.
Today, the visible state of the view only affects whether painting happens. In
the future it could affect more things which we don't want to touch here. Maybe
a FIXME saying that it would be good to have a more-direct way of telling the
web process to draw even if we're invisible would be enough here.

> Source/WebKit2/UIProcess/win/WebView.cpp:1482
> +void WebView::setIsVisible(bool isVisible)
> +{
> +    m_isVisible = isVisible;
> +    m_page->viewStateDidChange(WebPageProxy::ViewIsVisible);
> +}

Seems like onShowWindowEvent should call this function.